-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OEM: Provide Proxmox images #1783
base: main
Are you sure you want to change the base?
Conversation
8b6f5ae
to
4bdeec5
Compare
4bdeec5
to
9ef9191
Compare
9ef9191
to
709fca5
Compare
Build action triggered: https://github.com/flatcar/scripts/actions/runs/11589233717 |
Hello, there is an existing Igntion PR that should work at coreos/ignition#1790. Could you include the Ignition PR into this one so we can do further testing? |
This needs to be reworked first and we have to drop the afterburn integration in Flatcar as the afterburn PR relies on cloud-init userdata and because Flatcar will run coreos-cloudinit anyway if it doesn't see Ignition user-data we would have it processed twice. For the network config that can be quite confusing because the afterburn network unit would only support a subset. |
64b0e74
to
7c833ba
Compare
Triggered a new build with the Ignition PR included |
@pothos hey, it looks like the build never started, can you take a look please ? (cc @plgueugnon) |
@arcln hey, pothos is AFK for now. I'll take over this PR. A CI build has been triggered :) |
7c833ba
to
a52c30b
Compare
@arcln here's the proxmox image if you want to try it: http://bincache.flatcar-linux.net/images/amd64/9999.0.101+kai-proxmox-support/flatcar_production_proxmoxve_image.img.bz2 |
Thank you, I tried the image and it didn't work because of a problem in the ignition PR (see coreos/ignition#1790 (comment)). Can you please run a new build when the PR is fixed ? Thanks |
a52c30b
to
456e9bb
Compare
456e9bb
to
c1ce858
Compare
@arcln ah I see, I already got this issue once. I started a new build with an updated patch: https://github.com/flatcar/scripts/pull/1783/files#diff-c65e2140094c80c4b4ce5c7c8494b6e4e72b78ef0692d236ffee1fb3932e11c5R157 |
great. it seems that the build needs approval once again @tormath1 |
@arcln it builds directly on our Jenkins (github actions only build for qemu targets) - I'll let you know once it's done. |
@fhemberger @abuisine Afterburn with Proxmox support is already available in the last Flatcar Alpha release: https://www.flatcar.org/releases#release-4116.0.0. For Ignition, we are waiting for upstream release, I see they are working on promoting a new Ignition stable spec: coreos/ignition#1922 I assume a release will follow. EDIT: As expected an Ignition release is incoming: coreos/ignition#1960 |
@tormath1 I don't see it mentioned in the release notes for 4116.0.0, also no proxmoxve image file under downloads. |
@fhemberger No PromoxVE images yet because it's the purpose of this PR. As said, we are waiting for Ignition release before going ahead with this PR. I mentioned the release 4116.0.0 for the Afterburn part. |
159ec79
to
2bdf792
Compare
🔈 Proxmox users - Ignition and Afterburn are now released and ingested into Flatcar. I need your help to test this freshly built image: http://bincache.flatcar-linux.net/images/amd64/9999.9.100+kai-proxmox-support/flatcar_production_proxmoxve_image.img.bz2 using this documentation: https://github.com/flatcar/flatcar-website/pull/337/files (or any other method) |
@tormath1 Tried to test the image following the given documentation, fails to start:
Here is the complete dump of Ignition config is stored via EDIT: It was a documentation issue, one important line was missing which activates the cloud-init support in Proxmox VE. |
@tormath1 Added |
Great news, we should add this in the documentation. Thank you so much for testing and investigating this. So Ignition provisioning is working and what about |
@tormath1 I already amended the documentation PR, this is the process for me:
The I ran the script manually, after that the metadata was present:
There's no such service (or similarly named). 🤷 |
This image is failed to boot for me |
@mcbenjemaa Did you follow the procedure here? Could you please provide a bit more context? |
I just converted the VM into a template and then tried to add the config drive into a new clone, which didn't work. |
@mcbenjemaa You still need to provide your ignition.json. Proxmox' own cloud-init parameters are not enough (yet). Creating the VM in the GUI doesn't work at the moment, but should work via CLI (steps linked in my comment above). |
Can you try to mount |
@fhemberger @mcbenjemaa many thanks for trying again Flatcar on Proxmox! I started a discussion to avoid spamming and distracting the PR review. You can continue the discussion here if you need: flatcar/Flatcar#1573 |
@pothos Could you please add the following change to your PR: --- coreos-metadata.service 2024-10-25 16:14:39.499357398 +0200
+++ coreos-metadata.service-proxmoxve 2024-10-25 16:14:55.180153512 +0200
@@ -25,6 +25,8 @@
ConditionKernelCommandLine=|flatcar.oem.id=akamai
+ConditionKernelCommandLine=|flatcar.oem.id=proxmoxve
+
Description=Flatcar Metadata Agent
[Service] |
Co-authored-by: Kai Lüke <[email protected]> Signed-off-by: Mathieu Tortuyaux <[email protected]>
2bdf792
to
48e1b35
Compare
Hi @tormath1 , i've tested your build on Proxmox using the cloud-init configuration and it works well (at least for network configuration and SSH keys). By the way, the hostname configuration process strips any FQDN: if you set 'test.vm-1', only 'test' will be retained as the hostname. Will continue testing the ignition part. |
Now available here: http://bincache.flatcar-linux.net/images/amd64/9999.9.101+kai-proxmox-support/flatcar_production_proxmoxve_image.img.bz2 |
@tormath1 Works fine for me, |
I was able to sucessfully configure a proxmox VM using ignition including user creation, file creation, custom sysext deployment, systemd unit 🎉 |
Thanks everyone involved in the testing of the image, that's truly appreciated ❤️ There is one last thing to sort out: flatcar/Flatcar#1573 (reply in thread) before going ahead. |
Hi, we got an extra test with @donch if you do not mind : complete configuration via terraform (upload of snippets and |
This pulls in flatcar/bootengine#91
and flatcar/init#115 to run afterburn for
hostname, network, SSH key, and metadata attribute setup. The afterburn
support for the SSH key and hostname parses the user-data when it's
cloud-init. The coreos-cloudinit support is not there but can be added
in addition: We need to add a new provider that varies from the existing
config drive support because the file is called user-data and not
user_data, and it needs to look for a filesystem label cidata and not
config-2.
Related to: flatcar/Flatcar#1040
How to use
Follow-up: fix coreos-cloudinit as mentioned above, and better don't make it work through the mount unit trigger but explicitly
Testing done
Jenkins
changelog/
directory (user-facing change, bug fix, security fix, update)/boot
and/usr
size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.TODO: bump init and bootengine once related PRs are merged